-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable test results comment #12426
Disable test results comment #12426
Conversation
Disables the test results comment that gets added to PRs. As a team it was decided this was not useful.
Test Results1 054 files ± 0 1 054 suites ±0 2h 2m 57s ⏱️ - 2m 39s Results for commit 32ad540. ± Comparison against base commit fd19810. This pull request removes 721 and adds 585 tests. Note that renamed tests count towards both.
|
The action that comments is triggered upon the completion of the CI action. As a result it's not using workflow of this PR, but the workflow of main. This is why on this PR you still see the comment. As described here this change should work 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bors merge
Build succeeded: |
* fix(opensearch): Implement EventProcessMappingWriterOS * fix(opensearch): Rename EsEventProcessMappingDto to DbEventProcessMappingDto --------- Co-authored-by: Oleksandr Kriuchenko <oleksandr.kriuchenko-ext@camunda.com>
Description
Disables the test results comment that gets added to PRs. As a team it was decided this was not useful.
Related issues
closes #
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.