Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test results comment #12426

Merged
1 commit merged into from
Apr 14, 2023
Merged

Disable test results comment #12426

1 commit merged into from
Apr 14, 2023

Conversation

remcowesterhoud
Copy link
Contributor

Description

Disables the test results comment that gets added to PRs. As a team it was decided this was not useful.

Related issues

closes #

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

Disables the test results comment that gets added to PRs. As a team it was decided this was not useful.
@github-actions
Copy link
Contributor

Test Results

1 054 files  ±    0  1 054 suites  ±0   2h 2m 57s ⏱️ - 2m 39s
8 513 tests  - 136  8 487 ✔️  - 136  26 💤 ±0  0 ±0 
8 721 runs   - 136  8 695 ✔️  - 136  26 💤 ±0  0 ±0 

Results for commit 32ad540. ± Comparison against base commit fd19810.

This pull request removes 721 and adds 585 tests. Note that renamed tests count towards both.
DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={x=1, y=true, z=[1, 2, 3]}
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[56] collection=[Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[57] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[58] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[59] collection=[Left[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[60] collection=[Right[[B@1d3e5c4f], Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[61] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[62] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[63] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[64] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
…
DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={z=[1, 2, 3], y=true, x=1}
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[56] collection=[Left[[B@77d0a523]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[57] collection=[Right[[B@77d0a523], Left[[B@77d0a523]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[58] collection=[Left[[B@77d0a523], Right[[B@77d0a523]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[59] collection=[Left[[B@77d0a523], Left[[B@77d0a523]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[60] collection=[Right[[B@77d0a523], Right[[B@77d0a523], Left[[B@77d0a523]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[61] collection=[Right[[B@77d0a523], Left[[B@77d0a523], Right[[B@77d0a523]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[62] collection=[Right[[B@77d0a523], Left[[B@77d0a523], Left[[B@77d0a523]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[63] collection=[Left[[B@77d0a523], Right[[B@77d0a523], Right[[B@77d0a523]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[64] collection=[Left[[B@77d0a523], Right[[B@77d0a523], Left[[B@77d0a523]]
…

@remcowesterhoud
Copy link
Contributor Author

The action that comments is triggered upon the completion of the CI action. As a result it's not using workflow of this PR, but the workflow of main. This is why on this PR you still see the comment.

As described here this change should work 🤷

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bors merge

@ghost
Copy link

ghost commented Apr 14, 2023

Build succeeded:

@ghost ghost merged commit ab489d3 into main Apr 14, 2023
@ghost ghost deleted the disable_rest_results_publish branch April 14, 2023 15:36
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2024
* fix(opensearch): Implement EventProcessMappingWriterOS

* fix(opensearch): Rename EsEventProcessMappingDto to DbEventProcessMappingDto

---------

Co-authored-by: Oleksandr Kriuchenko <oleksandr.kriuchenko-ext@camunda.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants