migrate JournalMetrics to micrometer #27929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entangled90
added
benchmark
backport stable/8.5
entangled90
commented
Feb 10, 2025
monitor/grafana/zeebe.json
Outdated
| @@ -13172,7 +13172,7 @@ | |||
| "uid": "${DS_PROMETHEUS}" | |||
| }, | |||
| "editorMode": "code", | |||
| "expr": "sum(increase(atomix_segment_allocation_time_bucket{cluster=~\"$cluster\", namespace=~\"$namespace\", pod=~\"$pod\", partition=~\"$partition\"}[$__rate_interval])) by (le)", | |||
| "expr": "sum(increase(atomix_segment_allocation_time_bucket{cluster=~\"$cluster\", namespace=~\"$namespace\", pod=~\"$pod\", partition=~\"$partition\"}[$__rate_interval]) or increase(atomix_segment_allocation_time_seconds_bucket{cluster=~\"$cluster\", namespace=~\"$namespace\", pod=~\"$pod\", partition=~\"$partition\"}[$__rate_interval])) by (le)", | |||
There was a problem hiding this comment.
This is wrong: it should be
sum(increase(metric...)) or sum(increase(metric_seconds..))
npepinpe
approved these changes
Feb 10, 2025
Comment on lines
+37
to
+40
| @Override | ||
| public Duration[] getTimerSLOs() { | ||
| return super.getTimerSLOs(); | ||
| } |
There was a problem hiding this comment.
Same for all below just delegating to super
Comment on lines
294
to
310
| return Stream.of( | ||
| 100, | ||
| 1_000, | ||
| 5_000, | ||
| 10_0000, | ||
| 25_000, | ||
| 50_000, | ||
| 75_000, | ||
| 100_0000, | ||
| 250_000, | ||
| 500_000, | ||
| 75_000, | ||
| 1_000 * 1000, | ||
| 2_500 * 1000, | ||
| 5_000 * 1000) | ||
| .map(micros -> Duration.of(micros, ChronoUnit.MICROS)) | ||
| .toArray(Duration[]::new); |
There was a problem hiding this comment.
❌ Please create a constant out of it; I know it's annoying, but there's no reason to re-compute it every time.
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-27929-to-stable/8.5
git worktree add --checkout .worktree/backport-27929-to-stable/8.5 backport-27929-to-stable/8.5
cd .worktree/backport-27929-to-stable/8.5
git reset --hard HEAD^
git cherry-pick -x 19458c4632c5d305c131e5db031dbdc148cd7c39 9243aef0a235f3a82312076487aaca5b3940ef7e db71b8b44a680bb50932810c8d183144ebb8773f e3cdcf56cd45113dc6eab2b1695a45553a4fc66c 4a6befebd57a9780a037ce3ae64b6bb489fb8c10 3ed852e652c198099039d832bb4029f749dd5327 668db6e06c2284e93e0e807fc5114e89167ec678
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-27929-to-stable/8.6
git worktree add --checkout .worktree/backport-27929-to-stable/8.6 backport-27929-to-stable/8.6
cd .worktree/backport-27929-to-stable/8.6
git reset --hard HEAD^
git cherry-pick -x 19458c4632c5d305c131e5db031dbdc148cd7c39 9243aef0a235f3a82312076487aaca5b3940ef7e db71b8b44a680bb50932810c8d183144ebb8773f e3cdcf56cd45113dc6eab2b1695a45553a4fc66c 4a6befebd57a9780a037ce3ae64b6bb489fb8c10 3ed852e652c198099039d832bb4029f749dd5327 668db6e06c2284e93e0e807fc5114e89167ec678
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-27929-to-stable/8.7
git worktree add --checkout .worktree/backport-27929-to-stable/8.7 backport-27929-to-stable/8.7
cd .worktree/backport-27929-to-stable/8.7
git reset --hard HEAD^
git cherry-pick -x 19458c4632c5d305c131e5db031dbdc148cd7c39 9243aef0a235f3a82312076487aaca5b3940ef7e db71b8b44a680bb50932810c8d183144ebb8773f e3cdcf56cd45113dc6eab2b1695a45553a4fc66c 4a6befebd57a9780a037ce3ae64b6bb489fb8c10 3ed852e652c198099039d832bb4029f749dd5327 668db6e06c2284e93e0e807fc5114e89167ec678
git push --force-with-lease |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
# Description Backport of #27929 to `stable/8.5`. relates to #27147 original author: @entangled90
github-actions
bot
added
the
version:8.5.14
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
# Description Backport of #27929 to `stable/8.7`. relates to #27147 original author: @entangled90
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
# Description Backport of #27929 to `stable/8.6`. relates to #27147 original author: @entangled90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate module zeebe-journal to micrometer
Related issues
closes #27147