Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(idp extraction connector): implement new idp extraction outbound connector #3482

Merged
merged 11 commits into from
Oct 17, 2024
Merged

feat(idp extraction connector): implement new idp extraction outbound connector #3482

merged 11 commits into from
Oct 17, 2024

Conversation

sahilbhatoacamunda
Copy link
Contributor

Description

This PR introduces the integration of an outbound IDP extraction connector. This connector uses AWS Bedrock and Textract/Apache PdfBox to extract the text and then analyze it based on the input taxonomy.

Related issues

closes https://github.com/camunda/product-hub/issues/2527

Checklist

  • PR has a milestone or the no milestone label.

@sahilbhatoacamunda sahilbhatoacamunda requested a review from a team as a code owner October 15, 2024 14:44
@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java Fixed Show fixed Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java Fixed Show fixed Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java Fixed Show fixed Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java Fixed Show fixed Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java Fixed Show fixed Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java Fixed Show fixed Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java Fixed Show fixed Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java Fixed Show fixed Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java Fixed Show fixed Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java Fixed Show fixed Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java Fixed Show fixed Hide fixed
sbuettner
sbuettner reviewed Oct 16, 2024
View reviewed changes
...dp-extraction/src/main/java/io/camunda/connector/idp/extraction/model/ExtractionRequest.java Outdated
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;

public class ExtractionRequest extends AwsBaseRequest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more flexible in terms of cloud providers, I would recommend to create another class in your model like AwsRequest and just reference it ExtractionRequest so you dont have to inherit from the AwsBaseRequest here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also allow you to change this one to a record.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new class BaseRequest to extend from AwsBaseRequest .
Converted ExtractionRequest to a record.

sbuettner
sbuettner reviewed Oct 16, 2024
View reviewed changes
connectors/idp-extraction/src/main/resources/icon.svg Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanaSegal FYI

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are working on it :)

@sbuettner
Copy link
Contributor

@sahilbhatoacamunda Congrats to your first Connector 🥳 and great work. Added just a smaller comments regarding the model.

From my perspective its fine for now that you implemented your own polling although its somewhat duplicated in the textract connector right now but we can generalize later rather than now.

@sbuettner
Copy link
Contributor

sbuettner commented Oct 17, 2024 •
edited
Loading

@sahilbhatoacamunda Great work. Looks like there are some tests failing.

@sbuettner sbuettner added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 3938ea8 Oct 17, 2024
10 checks passed
@sbuettner sbuettner deleted the new-idp-extraction-outbound-connector branch October 17, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanaSegal YanaSegal YanaSegal left review comments

@sbuettner sbuettner sbuettner approved these changes

@mathias-vandaele mathias-vandaele Awaiting requested review from mathias-vandaele

Assignees
No one assigned
Labels
no milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sahilbhatoacamunda @CLAassistant @sbuettner @YanaSegal @mathias-vandaele