Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker-camunda-bpm-platform): Added sql and postgresql version arguements #296

Merged
merged 3 commits into from
May 6, 2024
Merged

feat(docker-camunda-bpm-platform): Added sql and postgresql version arguements #296

merged 3 commits into from
May 6, 2024

Conversation

punitdarira
Copy link
Contributor

@punitdarira punitdarira commented May 2, 2024 •
edited by danielkelemen
Loading

@punitdarira
Copy link
Contributor Author

#295

@danielkelemen danielkelemen self-requested a review May 3, 2024 08:38
@danielkelemen
Copy link
Member

danielkelemen commented May 3, 2024 •
edited
Loading

👍 Looks good to me.
🔧 Could you also add this new build-arg to the README so people can find it? I'd say a new sub-section here about how to build with custom db versions with an example cli would be nice.

I'll test your changes with a local branch in the meantime. #298

@punitdarira
Copy link
Contributor Author

👍 Looks good to me. 🔧 Could you also add this new build-arg to the README so people can find it? I'd say a new sub-section here about how to build with custom db versions with an example cli would be nice.

I'll test your changes with a local branch in the meantime. #298

Sure @danielkelemen

danielkelemen
danielkelemen reviewed May 6, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@punitdarira @danielkelemen
Update README.md to make link clickable
42f59d5 
related to #2692

Co-authored-by: Daniel Kelemen <danielkelemen@users.noreply.github.com>
danielkelemen
danielkelemen approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@danielkelemen danielkelemen merged commit 4769f12 into camunda:next May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@punitdarira punitdarira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punitdarira @danielkelemen