Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stacks): Add Docker QA Stack for 7.21.0-SNAPSHOT #59

Merged
merged 7 commits into from
Oct 5, 2023

Conversation

psavidis
Copy link
Contributor

@psavidis psavidis commented Oct 5, 2023

@tmetzke
Copy link
Member

tmetzke commented Oct 5, 2023

Thanks, @psavidis! Two things to consider:

@psavidis
Copy link
Contributor Author

psavidis commented Oct 5, 2023

Thanks, @psavidis! Two things to consider:

  • Hey, thanks for reminding me of the guide. I've reverted everything and started from scratch with a clean setup (i was missing the python command).
  • Also, didn't include WAS 9 as recommended.

Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The addition itself looks good.
🔧 There are some minor things to change here that make this more consistent.

new-stack-templates.json Outdated Show resolved Hide resolved
stack-templates.json Outdated Show resolved Hide resolved
psavidis and others added 2 commits October 5, 2023 15:07
Co-authored-by: Tobias Metzke-Bernstein <tobias.metzke@camunda.com>
@psavidis psavidis requested a review from tmetzke October 5, 2023 12:10
stack-templates.json Outdated Show resolved Hide resolved
stack-templates.json Outdated Show resolved Hide resolved
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 I think you can remove the new tomcat stacks, we won't need them.
👍 Other than that, we're good to go I think

@psavidis psavidis merged commit cd39150 into master Oct 5, 2023
1 check passed
@psavidis psavidis deleted the 3339-docker-qa-stack-7.21 branch October 5, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants