refactor(engine): Extract duplicated code for converting variables

camunda · Feb 8, 2024 · d762234 · d762234
1 parent bc7f8d8
commit d762234
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/engine/src/main/java/io/camunda/zeebe/process/test/engine/GrpcToLogStreamGateway.java b/engine/src/main/java/io/camunda/zeebe/process/test/engine/GrpcToLogStreamGateway.java
@@ -214,7 +214,7 @@ public void completeJob(
 
     final String variables = request.getVariables();
     if (!variables.isEmpty()) {
-      jobRecord.setVariables(BufferUtil.wrapArray(MsgPackConverter.convertToMsgPack(variables)));
+      jobRecord.setVariables(convertVariablesToMessagePack(variables));
     }
 
     writer.writeCommandWithKey(request.getJobKey(), jobRecord, recordMetadata);
@@ -373,7 +373,7 @@ public void throwError(
 
     final String variables = request.getVariables();
     if (!variables.isEmpty()) {
-      jobRecord.setVariables(BufferUtil.wrapArray(MsgPackConverter.convertToMsgPack(variables)));
+      jobRecord.setVariables(convertVariablesToMessagePack(variables));
     }
 
     writer.writeCommandWithKey(request.getJobKey(), jobRecord, recordMetadata);
@@ -400,8 +400,7 @@ public void publishMessage(
     messageRecord.setTimeToLive(request.getTimeToLive());
     final String variables = request.getVariables();
     if (!variables.isEmpty()) {
-      messageRecord.setVariables(
-          BufferUtil.wrapArray(MsgPackConverter.convertToMsgPack(variables)));
+      messageRecord.setVariables(convertVariablesToMessagePack(variables));
     }
 
     writer.writeCommandWithoutKey(messageRecord, recordMetadata);
@@ -442,8 +441,7 @@ public void setVariables(
 
     final String variables = request.getVariables();
     if (!variables.isEmpty()) {
-      variableDocumentRecord.setVariables(
-          BufferUtil.wrapArray(MsgPackConverter.convertToMsgPack(variables)));
+      variableDocumentRecord.setVariables(convertVariablesToMessagePack(variables));
     }
 
     variableDocumentRecord.setScopeKey(request.getElementInstanceKey());
@@ -596,8 +594,7 @@ public void broadcastSignal(
     final SignalRecord command = new SignalRecord().setSignalName(request.getSignalName());
 
     if (!request.getVariables().isEmpty()) {
-      command.setVariables(
-          BufferUtil.wrapArray(MsgPackConverter.convertToMsgPack(request.getVariables())));
+      command.setVariables(convertVariablesToMessagePack(request.getVariables()));
     }
 
     writer.writeCommandWithoutKey(
@@ -629,9 +626,7 @@ final var record = new ProcessInstanceModificationRecord();
         instruction.addVariableInstruction(
             new ProcessInstanceModificationVariableInstruction()
                 .setElementId(variable.getScopeId())
-                .setVariables(
-                    BufferUtil.wrapArray(
-                        MsgPackConverter.convertToMsgPack(variable.getVariables()))));
+                .setVariables(convertVariablesToMessagePack(variable.getVariables())));
       }
 
       record.addActivateInstruction(instruction);
@@ -668,8 +663,7 @@ private ProcessInstanceCreationRecord createProcessInstanceCreationRecord(
 
     final String variables = request.getVariables();
     if (!variables.isEmpty()) {
-      processInstanceCreationRecord.setVariables(
-          BufferUtil.wrapArray(MsgPackConverter.convertToMsgPack(variables)));
+      processInstanceCreationRecord.setVariables(convertVariablesToMessagePack(variables));
     }
     return processInstanceCreationRecord;
   }
@@ -686,12 +680,16 @@ private DecisionEvaluationRecord createDecisionEvaluationRecord(
 
     final String variables = request.getVariables();
     if (!variables.isEmpty()) {
-      record.setVariables(BufferUtil.wrapArray(MsgPackConverter.convertToMsgPack(variables)));
+      record.setVariables(convertVariablesToMessagePack(variables));
     }
 
     return record;
   }
 
+  private static DirectBuffer convertVariablesToMessagePack(final String variables) {
+    return BufferUtil.wrapArray(MsgPackConverter.convertToMsgPack(variables));
+  }
+
   public String getAddress() {
     return "0.0.0.0:" + port;
   }