Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using MigrateProcessInstance RPC #972

Closed
2 tasks
Tracked by #14907
korthout opened this issue Nov 10, 2023 · 1 comment · Fixed by #1012
Closed
2 tasks
Tracked by #14907

Support using MigrateProcessInstance RPC #972

korthout opened this issue Nov 10, 2023 · 1 comment · Fixed by #1012
Assignees
@korthout
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior target:8.4 Issue must be completed before this target release

Comments

@korthout
Copy link
Member

korthout commented Nov 10, 2023 •
edited
Loading

Description

With camunda/camunda#15119 we have added a new MigrateProcessInstance RPC to the gRPC protocol. We must define this endpoint in the ZPT engine.

  • Implement the RPC in the GrpcToLogStreamGateway
    • Add a response mapper to the GrpcResponseMapper

Would be nice to add a test case that shows that we can migrate a process instance in ZPT and then continue the process instance in the new model.

Blocked by
@korthout korthout added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Nov 10, 2023
@korthout korthout mentioned this issue Nov 10, 2023
Closed
5 tasks
@berkaycanbc berkaycanbc self-assigned this Dec 7, 2023
@korthout korthout added the target:8.4 Issue must be completed before this target release label Dec 8, 2023
@berkaycanbc berkaycanbc removed the target:8.4 Issue must be completed before this target release label Dec 21, 2023
@abbasadel
Copy link
Contributor

abbasadel commented Dec 21, 2023 •
edited
Loading

We think this is nice to have in 8.4 but not a blocker for the release.
If you managed to work on this before the official release date, please remember to update the release branch

@berkaycanbc berkaycanbc assigned korthout and unassigned berkaycanbc Jan 2, 2024
@korthout korthout mentioned this issue Jan 2, 2024
Merged
7 tasks
@korthout korthout added the target:8.4 Issue must be completed before this target release label Jan 2, 2024
ghost pushed a commit that referenced this issue Jan 2, 2024
@korthout
merge: #1012
3af0e04 
1012: Support using process instance migration from the zeebe client r=korthout a=korthout

## Description

<!-- Please explain the changes you made here. -->

This adds support for the new `MigrateProcessInstance` RPC to ZPT, such that users can try migrating process instances from ZPT. This allows testing migrations before doing so in production.

> [!NOTE]
> This does not add assertions for the migration. That is out of scope.

Additionally, this fixes a test case that no longer added value. The test case was intended to ensure that we don't forget supporting RPCs in ZPT, but the implementation of the test did not function correctly anymore. Now it is able to correctly detect unsupported RPCs again, which [highlighted that `streamActivatedJobs` is not supported by ZPT](camunda/camunda#11231 (comment)).

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #972

<!-- Cut-off marker
_All lines under and including the cut-off marker will be removed from the merge commit message_

## Definition of Ready

Please check the items that apply, before requesting a review.

You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda/zeebe/wiki/Pull-Requests-and-Code-Reviews).

* [ ] I've reviewed my own code
* [ ] I've written a clear changelist description
* [ ] I've narrowly scoped my changes
* [ ] I've separated structural from behavioural changes
-->

## Definition of Done

<!-- Please check the items that apply, before merging or (if possible) before requesting a review. -->

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [x] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to backport the fix

Testing:
* [x] There are unit/integration tests that verify all acceptance criterias of the issue
* [x] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually

Documentation:
* [ ] Javadoc has been written
* [ ] The documentation is updated


Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
ghost pushed a commit that referenced this issue Jan 2, 2024
@korthout
merge: #1012
d5e3685 
1012: Support using process instance migration from the zeebe client r=korthout a=korthout

## Description

<!-- Please explain the changes you made here. -->

This adds support for the new `MigrateProcessInstance` RPC to ZPT, such that users can try migrating process instances from ZPT. This allows testing migrations before doing so in production.

> [!NOTE]
> This does not add assertions for the migration. That is out of scope.

Additionally, this fixes a test case that no longer added value. The test case was intended to ensure that we don't forget supporting RPCs in ZPT, but the implementation of the test did not function correctly anymore. Now it is able to correctly detect unsupported RPCs again, which [highlighted that `streamActivatedJobs` is not supported by ZPT](camunda/camunda#11231 (comment)).

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #972

<!-- Cut-off marker
_All lines under and including the cut-off marker will be removed from the merge commit message_

## Definition of Ready

Please check the items that apply, before requesting a review.

You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda/zeebe/wiki/Pull-Requests-and-Code-Reviews).

* [ ] I've reviewed my own code
* [ ] I've written a clear changelist description
* [ ] I've narrowly scoped my changes
* [ ] I've separated structural from behavioural changes
-->

## Definition of Done

<!-- Please check the items that apply, before merging or (if possible) before requesting a review. -->

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [x] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to backport the fix

Testing:
* [x] There are unit/integration tests that verify all acceptance criterias of the issue
* [x] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually

Documentation:
* [ ] Javadoc has been written
* [ ] The documentation is updated


Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
@ghost ghost closed this as completed in 67c23d8 Jan 2, 2024
@backport-action backport-action mentioned this issue Jan 3, 2024
Merged
ghost pushed a commit that referenced this issue Jan 3, 2024
@korthout
merge: #1013
4894ff7 
1013: [Backport release-8.4.0] Support using process instance migration from the zeebe client r=github-actions[bot] a=backport-action

# Description
Backport of #1012 to `release-8.4.0`.

relates to #972

Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korthout korthout

Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior target:8.4 Issue must be completed before this target release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support using process instance migration from the zeebe client camunda/zeebe-process-test
3 participants
@abbasadel @korthout @berkaycanbc