Timer events fail with specific values

[ana-vinogradova-camunda]

Description

Fix for this bug

The root cause of this bug was in Bytes class compareTo(final Bytes other) method.

Before we used to compare byte arrays tin the following way:

if (ourByte < otherByte) {
        return SMALLER;
    } else if (ourByte > otherByte) {
        return BIGGER;
    } // else { // = equals -> continue }

This was leading to incorrect date comparison as we were comparing signed bytes and sometimes the date that was supposed to come after some other date had a negative byte (ex. -97).

For example:
2023.10.10 15:50:00 date will look as follows when converted to bytes array: [0, 0, 1, -117, 25...]
2023.11.5 15:50:00 date will look as follows when converted to bytes array: [0, 0, 1, -117, -97...]

When comparing these 2 dates we would previously get 2023.11.5 15:50:00 as a smaller date that would result in 2023.10.10 15:50:00 timer event to not be activated.

The fix:
I am using Guava UnsignedBytes.compare(ourByte, otherByte) method instead as it compares the two specified byte values, treating them as unsigned values between 0 and 255 inclusive. For example, (byte) -127 is considered greater than (byte) 127 because it is seen as having the value of positive 129.

Related issues

closes #975

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

• The changes are backwards compatibility with previous versions
• If it fixes a bug then PRs are created to backport the fix

Testing:

• There are unit/integration tests that verify all acceptance criterias of the issue
• New tests are written to ensure backwards compatibility with further versions
• The behavior is tested manually

Documentation:

• Javadoc has been written
• The documentation is updated

[github-actions]

Test Results

 50 files  + 3   50 suites  +3   1m 47s ⏱️ +2s
134 tests + 5  134 ✅ + 5  0 💤 ±0  0 ❌ ±0 
426 runs  +15  426 ✅ +15  0 💤 ±0  0 ❌ ±0 

Results for commit 5abd87e. ± Comparison against base commit 047c815.

♻️ This comment has been updated with latest results.

[berkaycanbc]

🔧 Instead of depending on the external library, we can convert values to int using Java's Byte.toUnsignedInt(byte x); and keep the original comparison. 👍

[lenaschoenburg]

There's also Arrays#compareUnsigned which does exactly what we want and probably faster than what we can implement.

[ana-vinogradova-camunda]

Thank you for the suggestion, sounds great 👍🏻

[tmetzke]

👍 I like the new test cases and that we fix this in a "forward" manner.
🔧 Let's replace the custom comparison logic in Bytes completely with a call to Arrays#compareUnsigned. @oleschoenburg is right, this does exactly what we want and way more efficiently than what is currently implemented here. For example, it has way better early-exit conditions and is null-safe.

[tmetzke]

👍 The compare method is so much better now 🚀
🔧 Some smaller suggestions regarding test naming and test class setup. The test cases themselves look good to me, good job ⭐

[saig0]

/backport

[backport-action]

Successfully created backport PR for stable/8.4:

• [Backport stable/8.4] Timer events fail with specific values #1070

[ana-vinogradova-camunda]

/backport

[backport-action]

Backport failed for stable/8.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.1
git worktree add -d .worktree/backport-1028-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-1028-to-stable/8.1
git switch --create backport-1028-to-stable/8.1
git cherry-pick -x e82cc5c9457679b3490a4029101ee080e73011a2 563b095866a265b782770575e8d94fdfcc0a5b1f d9b3b5e3fd067b55eee0c4e31be9a605fb8d968b 320bcab2c0a83a42aff0b8eb52e44d6b5f077536 9dca20bc2b120d53d32408ef363a0dee0e96a429 5abd87ecf972ce569f8498a37e08b697430e6bf4

[backport-action]

Backport failed for stable/8.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.2
git worktree add -d .worktree/backport-1028-to-stable/8.2 origin/stable/8.2
cd .worktree/backport-1028-to-stable/8.2
git switch --create backport-1028-to-stable/8.2
git cherry-pick -x e82cc5c9457679b3490a4029101ee080e73011a2 563b095866a265b782770575e8d94fdfcc0a5b1f d9b3b5e3fd067b55eee0c4e31be9a605fb8d968b 320bcab2c0a83a42aff0b8eb52e44d6b5f077536 9dca20bc2b120d53d32408ef363a0dee0e96a429 5abd87ecf972ce569f8498a37e08b697430e6bf4

[backport-action]

Successfully created backport PR for stable/8.3:

• [Backport stable/8.3] Timer events fail with specific values #1071