Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update java client dependency #1197

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

nicpuppa
Copy link
Contributor

Description

Due to Zeebe Java Client refactor/rename we need to update also the dependency here

Related issues

related camunda/camunda#19482

@nicpuppa nicpuppa requested review from tmetzke and korthout June 27, 2024 07:41
Copy link

Test Results

 50 files   50 suites   1m 24s ⏱️
138 tests 138 ✅ 0 💤 0 ❌
438 runs  438 ✅ 0 💤 0 ❌

Results for commit ff942bf.

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 So this means that any project building against a SNAPSHOT version of zeebe-client-java must either make this change or move to a non-SNAPSHOT release. I think that's fine, as SNAPSHOTs should only be for internal development.

LGTM 👍

Thanks @nicpuppa

@korthout
Copy link
Member

korthout commented Jun 27, 2024

Here's what happens to projects depending on a SNAPSHOT of zeebe-client-java:

First it downloads the maven-metadata.xml of the zeebe-client-java:

[INFO] Downloading from camunda-nexus: https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/io/camunda/zeebe-client-java/8.6.0-SNAPSHOT/maven-metadata.xml
[INFO] Downloaded from camunda-nexus: https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/io/camunda/zeebe-client-java/8.6.0-SNAPSHOT/maven-metadata.xml (1.2 kB at 5.9 kB/s)

Then it sees in there an entry for the latest snapshot:

<?xml version="1.0" encoding="UTF-8"?>
<metadata modelVersion="1.1.0">
  <groupId>io.camunda</groupId>
  <artifactId>zeebe-client-java</artifactId>
  <version>8.6.0-SNAPSHOT</version>
  <versioning>
    <snapshot>
      <timestamp>20240627.070523</timestamp>
      <buildNumber>1073</buildNumber>
    </snapshot>
    <lastUpdated>20240627073119</lastUpdated>
    <snapshotVersions>
      <snapshotVersion>
        <classifier>sources</classifier>
        <extension>jar</extension>
        <value>8.6.0-20240619.224723-1010</value>
        <updated>20240619224723</updated>
      </snapshotVersion>
      <snapshotVersion>
        <classifier>javadoc</classifier>
        <extension>jar</extension>
        <value>8.6.0-20240619.220911-1010</value>
        <updated>20240619220911</updated>
      </snapshotVersion>
      <snapshotVersion>
        <extension>jar</extension>
        <value>8.6.0-20240627.070523-1073</value>
        <updated>20240627070523</updated>
      </snapshotVersion>
      <snapshotVersion>
        <extension>pom</extension>
        <value>8.6.0-20240627.070523-1073</value>
        <updated>20240627070523</updated>
      </snapshotVersion>
    </snapshotVersions>
  </versioning>
</metadata>

And downloads the pom of that specific SNAPSHOT of zeebe-client-java:

[INFO] Downloading from camunda-nexus: https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/io/camunda/zeebe-client-java/8.6.0-SNAPSHOT/zeebe-client-java-8.6.0-20240626.233001-1072.pom
[INFO] Downloaded from camunda-nexus: https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/io/camunda/zeebe-client-java/8.6.0-SNAPSHOT/zeebe-client-java-8.6.0-20240626.233001-1072.pom (3.5 kB at 17 kB/s)

Then it sees that this has a relocation in that pom and tries to download the same version of the relocated pom:

[INFO] Downloading from camunda-nexus: https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/io/camunda/camunda-client-java/8.6.0-SNAPSHOT/camunda-client-java-8.6.0-20240626.233001-1072.pom
Warning:  The POM for io.camunda:camunda-client-java:jar:8.6.0-20240626.233001-1072 is missing, no dependency information available
Warning:  The POM for io.camunda:camunda-client-java:jar:8.6.0-20240626.233001-1072 is missing, no dependency information available
...
Warning:  The artifact io.camunda:zeebe-client-java:jar:8.6.0-20240626.233001-1072 has been relocated to io.camunda:camunda-client-java:jar:8.6.0-20240626.233001-1072
...
Error:  Failed to execute goal on project zeebe-process-test-api: Could not resolve dependencies for project io.camunda:zeebe-process-test-api:jar:8.6.0-alpha2-rc2-SNAPSHOT: Could not find artifact io.camunda:camunda-client-java:jar:8.6.0-20240626.233001-1072 in camunda-nexus (https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/) -> [Help 1]

But that artifact doesn't exist.

@nicpuppa nicpuppa merged commit 4c17c70 into main Jun 27, 2024
10 checks passed
@nicpuppa nicpuppa deleted the change-java-client-dependency branch June 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants