Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix httpcore5 dependency convergence issue #1203

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix httpcore5 dependency convergence issue #1203

merged 1 commit into from
Jul 11, 2024

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Jul 11, 2024 •
edited
Loading

Description

Due to a clash in dependencies ZPT gains 2 versions of httpcore5. I've set it to the latest version.

Related issues

closes #1201

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@remcowesterhoud
fix: httpcore5 dependency convergence issue
5bd1468 
Due to a clash in dependencies ZPT gains 2 versions of httpcore5. I've set it to the latest version.
deepthidevaki
deepthidevaki approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please close #1202

@github-actions GitHub Actions
Copy link

Test Results

 50 files   50 suites   1m 28s ⏱️
138 tests 138 ✅ 0 💤 0 ❌
438 runs  438 ✅ 0 💤 0 ❌

Results for commit 5bd1468.

@remcowesterhoud remcowesterhoud merged commit b70f4da into main Jul 11, 2024
10 checks passed
@remcowesterhoud remcowesterhoud deleted the fix-dep-convergence branch July 11, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthidevaki deepthidevaki deepthidevaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remcowesterhoud @deepthidevaki