Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USER and CLOCK ValueTypes to the RecordStreamLogger #1224

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

remcowesterhoud
Copy link
Contributor

Description

These ValueTypes were missing causing failing tests on the main branch. I've added a quick summary of the records to the logger to fix this problem.

Related issues

N/A

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

These ValueTypes were missing causing failing tests on the main branch. I've added a quick summary of the records to the logger to fix this problem.
@remcowesterhoud remcowesterhoud requested a review from a team August 16, 2024 06:28
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tmetzke
Copy link
Member

tmetzke commented Aug 16, 2024

Interesting CI failures 🤔 They can't be related to the changes here, as far as I can see.

@remcowesterhoud remcowesterhoud added this pull request to the merge queue Aug 16, 2024
Copy link

Test Results

 41 files  ± 0   41 suites  ±0   17s ⏱️ -31s
134 tests  -  1  102 ✅  - 31  0 💤 ±0  0 ❌  - 2  32 🔥 +32 
426 runs  +60  330 ✅  - 33  0 💤 ±0  0 ❌  - 3  96 🔥 +96 

For more details on these errors, see this check.

Results for commit 51d7bd6. ± Comparison against base commit 29c38e4.

This pull request removes 1 test.
io.camunda.zeebe.process.test.engine.GrpcToLogStreamGatewayTest ‑ testImplementsGatewayEndpoint(String)[22]

@remcowesterhoud remcowesterhoud removed this pull request from the merge queue due to a manual request Aug 16, 2024
@remcowesterhoud
Copy link
Contributor Author

@tmetzke Just saw them as well. I'll still see if I can fix them in this PR 😄

@remcowesterhoud
Copy link
Contributor Author

Nevermind, it becomes complex fast. I'll create an issue for it 😄

@remcowesterhoud remcowesterhoud added this pull request to the merge queue Aug 16, 2024
@remcowesterhoud remcowesterhoud merged commit 4d972fb into main Aug 16, 2024
5 of 10 checks passed
@remcowesterhoud remcowesterhoud deleted the add-missing-valuetypes branch August 16, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants