Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide LogStream with a clock #1226

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Provide LogStream with a clock #1226

merged 1 commit into from
Aug 16, 2024

Conversation

remcowesterhoud
Copy link
Contributor

Description

Due to changes in Zeebe we need to pass the ActorClock along to the StreamProcessor

Related issues

closes #1225

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

Due to changed in Zeebe we need to pass the ActorClock along to the StreamProcessor
Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you 🚀

@remcowesterhoud remcowesterhoud added this pull request to the merge queue Aug 16, 2024
Copy link

Test Results

 47 files  +6   47 suites  +6   1m 7s ⏱️ +50s
135 tests +1  135 ✅ +33  0 💤 ±0  0 ❌ ±0 
429 runs  +3  429 ✅ +99  0 💤 ±0  0 ❌ ±0 

Results for commit e68990b. ± Comparison against base commit 4d972fb.

Merged via the queue into main with commit 805e6f5 Aug 16, 2024
6 of 10 checks passed
@remcowesterhoud remcowesterhoud deleted the 1225-actorclock branch August 16, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zeebe's new Clock mechanism should be supported in ZPT
2 participants