Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty logger for authorization records #1231

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

remcowesterhoud
Copy link
Contributor

Description

Authorizations aren't supported in the next version. The record is bound to change so it's not worth adding a proper logger for this value type right now. It likely isn't worth adding one in the future either, since ZPT is in the process of being deprecated.

Related issues

N/A

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

Authorizations aren't supported in the next version. The record is bound to change so it's not worth adding a proper
logger for this value type right now. It likely isn't worth adding one in the future either, since ZPT is in the process
of being deprecated.
Instead of logging nothing we can use the toString method of the record
Copy link

Test Results

 45 files   - 2   45 suites   - 2   1m 3s ⏱️ -6s
135 tests ±0  135 ✅ ±0  0 💤 ±0  0 ❌ ±0 
428 runs   - 1  428 ✅  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit 1a30598. ± Comparison against base commit 9e5884a.

@remcowesterhoud
Copy link
Contributor Author

CI fails because of #1230 so we can't merge it yet until that one's fixed as well.

@remcowesterhoud remcowesterhoud changed the base branch from main to 1230-timer-test-fix August 27, 2024 11:59
@remcowesterhoud remcowesterhoud merged commit 14318b8 into 1230-timer-test-fix Aug 27, 2024
6 of 10 checks passed
@remcowesterhoud remcowesterhoud deleted the add-authorization-valuetype branch August 27, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants