Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add REDISTRIBUTION value type to logger #1266

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

tmetzke
Copy link
Member

@tmetzke tmetzke commented Nov 15, 2024

Description

Adds the REDISTRIBUTION value type to the record logger introduced with camunda/camunda#24260.

Related issues

related to camunda/camunda#24013

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@tmetzke tmetzke self-assigned this Nov 15, 2024
@tmetzke
Copy link
Member Author

tmetzke commented Nov 15, 2024

@lenaschoenburg, if there is a specialized logging you'd consider appropriate here, feel free to make a proposal.

@lenaschoenburg
Copy link
Member

Oh thanks for implementing this! I don't thinks it's important how we log it because redistribution will never get triggered in ZPT anyway. So any format works for me.

@tmetzke
Copy link
Member Author

tmetzke commented Nov 15, 2024

Oh thanks for implementing this! I don't thinks it's important how we log it because redistribution will never get triggered in ZPT anyway. So any format works for me.

That's what I assumed as well and why I went for toString 😄 👍

@tmetzke tmetzke enabled auto-merge November 15, 2024 07:03
@tmetzke tmetzke added this pull request to the merge queue Nov 15, 2024
Copy link

Test Results

 49 files   - 1   49 suites   - 1   1m 28s ⏱️ -8s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
435 runs   - 3  435 ✅  - 3  0 💤 ±0  0 ❌ ±0 

Results for commit ae07a80. ± Comparison against base commit 8048733.

Merged via the queue into main with commit ea25c80 Nov 15, 2024
9 of 10 checks passed
@tmetzke tmetzke deleted the tmb-log-redistribution-type branch November 15, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants