Containerize in memory engine #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proof that the docker build and push works (names might differ a bit): |
korthout
requested changes
Feb 11, 2022
There was a problem hiding this comment.
Thanks @remcowesterhoud 🐳
Generally looks good, but I have some questions.
engine/src/main/java/io/camunda/zeebe/process/test/engine/EngineFactory.java
Show resolved
Hide resolved
|
@korthout Thanks for you review 🙇 I've answered your questions and made some changes. Please check again when you have the time! |
korthout
approved these changes
Feb 11, 2022
- Added a main class to make the engine executable - Switched to a static port for the grpc server, so we always know what port we need to send the traffic to. - Added a Dockerfile to make it possible to build a container.
Both the deploy workflow and the build/test workflow have to build and run the unit tests. By making the build/test workflow reusable we can call it in the deploy workflow.
Added a job to the deployment pipeline which will build a container from the engine, and push it to dockerhub. The container will default to the "latest" tag. If a new release is created in GitHub the name of the tag attached to this release will be used as the image tag, unless this release is a SNAPSHOT release.
One of the dependencies (zeebe-workflow-engine) requires this dependency. Running the engine without this will result in errors: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. SLF4J: Failed to load class "org.slf4j.impl.StaticMDCBinder". SLF4J: Defaulting to no-operation MDCAdapter implementation. SLF4J: See http://www.slf4j.org/codes.html#no_static_mdc_binder for further details. Adding this dependency resolves this issue and fixes the logging of the engine.
remcowesterhoud
force-pushed
the
5-containerize
branch
from
a63412c to
9932fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #5
Next steps will be done in #7
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: