Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase idle state monitor grace periode #180

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Increase idle state monitor grace periode #180

merged 1 commit into from
Feb 11, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Feb 10, 2022

Description

We have a bunch of tests that are flaky on the slow GitHub runners, because they think the engine is idle when it isn't.

At some point #133 might be a better solution for this, but this issue doesn't have my priority for now and these flaky tests are bothering me.

Related issues

closes #178

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@github-actions
Copy link

github-actions bot commented Feb 10, 2022

Unit Test Results

  81 files    81 suites   4m 51s ⏱️
154 tests 154 ✔️ 0 💤 0
462 runs  462 ✔️ 0 💤 0

Results for commit 8835938.

♻️ This comment has been updated with latest results.

We have a bunch of tests that are flaky on the slow GitHub runners, because they think the engine is idle when it isnt'
@remcowesterhoud remcowesterhoud changed the title DRAFT: Add wait for active state Increase idle state grace periode Feb 10, 2022
@remcowesterhoud remcowesterhoud changed the title Increase idle state grace periode Increase idle state monitor grace periode Feb 10, 2022
@pihme pihme merged commit 5933400 into main Feb 11, 2022
@pihme pihme deleted the flaky-tests branch February 11, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProcessEventInspectionsTest.testFindLastProcessInstance is flaky
2 participants