Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing quote #183

Merged
merged 2 commits into from
Feb 11, 2022
Merged

fix missing quote #183

merged 2 commits into from
Feb 11, 2022

Conversation

zambrovski
Copy link
Contributor

@zambrovski zambrovski commented Feb 10, 2022 •
edited
Loading

Description

Somewhat silly, but the message in the assert of the variable value has a missing closing quote by the display of the JSON value.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@remcowesterhoud remcowesterhoud self-requested a review February 11, 2022 08:17
@github-actions
Copy link

Unit Test Results

  81 files    81 suites   3m 41s ⏱️
154 tests 154 ✔️ 0 💤 0 ❌
462 runs  462 ✔️ 0 💤 0 ❌

Results for commit 25f69b7.

remcowesterhoud
remcowesterhoud approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 😄

@remcowesterhoud remcowesterhoud merged commit 60cecea into camunda:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcowesterhoud remcowesterhoud remcowesterhoud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zambrovski @remcowesterhoud