Cleanup compile time dependencies #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slf4j-simple is more lightweight than log4j. We should replace the usage with slf4j-simple. First step is deleting the dependency to log4j.
We shouldn't add a logging implementation to our dependencies. This is troublesome for users, as they'll have to the same logging implementation. Or they have to exclude the dependency manually. By changing the compile time scoped dependencies to slf4j-api we can solve this problem. Wherever we need an implementation, we should add it to the test scoped dependencies.
The QA tests use apache commons for some convenience. Before we got this as a transitive dependency. Since we use it we should explicitly declare it in the pom.
As a leftover from the module split there are some modules which contain dependencies that are no longer used in the module. This change removes these dependencies. It also fixes the scope of 1 dependency to test scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets rid of dependencies to any
slf4jimplementation. Instead we make use of theslf4j-api. In our tests we still need to provide an implementation which is done by addingslf4j-simpleas a test scoped dependency. I got rid oflog4jasslf4j-simpleis more lightweight.I've also gone through the other dependencies. As a result of the module split some of these were unused, or wrongly scoped. This PR also solves these issues.
Related issues
closes #174
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: