Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup-java caching #260

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Use setup-java caching #260

merged 1 commit into from
Mar 15, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Mar 15, 2022

Description

Setup-java provides caching using the cache action we were already using. Using this allows us to remove a separate step and a bunch of duplicated logic. It might also resolve an issue where caching was not working properly.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

Setup-java provides caching using the cache action we were already using. Using this allows us to remove a separate step and a bunch of duplicated logic. It might also resolve an issue where caching was not working properly.
@github-actions
Copy link

github-actions bot commented Mar 15, 2022

Unit Test Results

128 files  128 suites   6m 1s ⏱️
325 tests 325 ✔️ 0 💤 0
788 runs  788 ✔️ 0 💤 0

Results for commit eff01c4.

♻️ This comment has been updated with latest results.

@remcowesterhoud remcowesterhoud requested a review from pihme March 15, 2022 14:59
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@remcowesterhoud
Copy link
Contributor Author

It's still downloading a bunch of crap even though it's using the same cache each build. So it's an improvement, but I don't think it fixed the caching.

@remcowesterhoud remcowesterhoud merged commit fb13fb6 into main Mar 15, 2022
@remcowesterhoud remcowesterhoud deleted the workflow_caching branch March 15, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants