NPE during logging #307
Merged
NPE during logging #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable with a value of null would produce a NPE during the logging of the record stream. This nullcheck fixes this issue.
pihme
suggested changes
Apr 11, 2022
filters/src/test/java/io/camunda/zeebe/process/test/filters/logger/RecordStreamLoggerTest.java
Show resolved
Hide resolved
filters/src/main/java/io/camunda/zeebe/process/test/filters/logger/RecordStreamLogger.java
Outdated
Show resolved
Hide resolved
remcowesterhoud
force-pushed
the
305_NPE_during_logging
branch
from
4ffde56 to
53e0adb
Compare
This class was mostly not tested. We tested if we had a logger for all records, but we did not test the fucntionality of the logger itself. It doesn't contain much logic but by adding some tests around it we can hopefully prevent NPE's in the future.
remcowesterhoud
force-pushed
the
305_NPE_during_logging
branch
from
53e0adb to
ba7227d
Compare
pihme
approved these changes
Apr 12, 2022
|
Successfully created backport PR #310 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Variable with a null value produce NPE when logging the record stream. This PR adds a null check and a bunch of tests for our logger to prevent this in the future.
Related issues
closes #305
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: