Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't provide test scope in dependencyManagement #317

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Apr 13, 2022

Description

Providing test scope could result in issues. For example:

The zeebe-workflow-engine has commons-lang3 as a dependency. Since it is in our dependencyManagement with a test scope, this means zeebe-worklfow-engine will get this dependency test scoped as well. This results in ClassNotFoundExceptions, since zeebe-workflow-engine expects it to be available on the classpath when running the application regularly.

This would work fine with the embedded version, as it runs in a test scope. The testcontainer version however does not work as the engine does not run in test scope in the container.

Note: as part of a different PR these scopes were already removed from the main branch. Since this commit contains more changes I couldn't cherry-pick this. Therefore this is a new commit targeted to the stable/8.0 branch.

Related issues

closes #300

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

Doing this could result in issues. For example:

The zeebe-workflow-engine has commons-lang3 as a dependency. Since it is in our dependencyManagement with a test scope, this means zeebe-worklfow-engine will get this dependency test scoped as well. This results in ClassNotFoundExceptions, since zeebe-workflow-engine expects it to be available on the classpath when running the application regularly.
@remcowesterhoud remcowesterhoud requested a review from pihme April 13, 2022 08:24
@github-actions
Copy link

Unit Test Results

   140 files     140 suites   8m 13s ⏱️
   262 tests    262 ✔️ 0 💤 0
1 004 runs  1 004 ✔️ 0 💤 0

Results for commit 95977c5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants