Don't provide test scope in dependencyManagement #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Providing test scope could result in issues. For example:
The zeebe-workflow-engine has commons-lang3 as a dependency. Since it is in our dependencyManagement with a test scope, this means zeebe-worklfow-engine will get this dependency test scoped as well. This results in ClassNotFoundExceptions, since zeebe-workflow-engine expects it to be available on the classpath when running the application regularly.
This would work fine with the embedded version, as it runs in a test scope. The testcontainer version however does not work as the engine does not run in test scope in the container.
Note: as part of a different PR these scopes were already removed from the main branch. Since this commit contains more changes I couldn't cherry-pick this. Therefore this is a new commit targeted to the stable/8.0 branch.
Related issues
closes #300
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: