Support sequence flow in hasPassedElement assertions #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sequence flows will never have an event with an ELEMENT_COMPLETED intent. Instead they get a single event with a SEQUENCE_FLOW_TAKEN intent. Because of this we would always filter out any sequence flows in the assertion, making it impossible to assert that a specific flow has been passed. By adding the SEQUENCE_FLOW_TAKEN intent we include sequence flows in our lists and allow asserting whether or not they have been passed.
|
Successfully created backport PR #323 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sequence flows will never have an event with an ELEMENT_COMPLETED intent. Instead they get a single event with a SEQUENCE_FLOW_TAKEN intent. Because of this we would always filter out any sequence flows in the assertion, making it impossible to assert that a specific flow has been passed. By adding the SEQUENCE_FLOW_TAKEN intent we include sequence flows in our lists and allow asserting whether or not they have been passed.
Related issues
closes #318
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: