Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zeebe dependency to 8.0.1 #334

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Update Zeebe dependency to 8.0.1 #334

merged 1 commit into from
Apr 21, 2022

Conversation

npepinpe
Copy link
Member

Description

This PR bumps the Zeebe dependency to 8.0.1.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@github-actions
Copy link

Unit Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit beffcc8.

@remcowesterhoud
Copy link
Contributor

@npepinpe Just a heads up that this PR should point to the stable/8.0 branch instead of main. Not sure if this is clear enough in the release process.

@npepinpe npepinpe changed the base branch from main to stable/8.0 April 21, 2022 12:22
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@npepinpe
Copy link
Member Author

Are the build and test on different OS's run in sequence and not in parallel? 🤔 It kind of looks like that's what happened

@remcowesterhoud
Copy link
Contributor

Yes they are 😞

It was changed here #157
Running them in parallel caused a lot of flakiness which was presumably due to the speed of runners.

@npepinpe
Copy link
Member Author

They don't run in different machines? I mean they need to run on different OS's, I always assumed they then ran on different machines 😄 Oh well, TIL

@remcowesterhoud
Copy link
Contributor

remcowesterhoud commented Apr 21, 2022

I truly don't know. It could very well be that this wasn't the reason. All I know is it did solve the issue 😅

@npepinpe npepinpe merged commit 6213bdb into stable/8.0 Apr 21, 2022
@npepinpe npepinpe deleted the np-bump-zeebe branch April 21, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants