[Backport stable/8.0] Make gRPC response sender thread-safe #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The GatewayRequestStore is a utility class that will be used by the GrpcToLogStreamGateway and the GrpcResponseWriter to share request between the two of them. The GrpcToLogStreamGateway will store new requests in here. The GrpcResponseWriter will take these requests out and write the correct response to the correct request. This store has to be thread-safe. Because of this we are using a ConcurrentHashMap as well as an AtomicLong (cherry picked from commit 95bd731)
The single threaded executor was causing issues in combination with the GrpcResponseWriter. The response was send in a different thread from where the request was received. Since the writer reuses a DirectBuffer to store the record this could result in the buffer being modified by a thread, whilst the response was still being send in the single executor thread. (cherry picked from commit e782635)
Incoming requests need to be stored in the new GatewayRequestStore so the GrpcResponseWriter will be able to access them. (cherry picked from commit 8d29f4f)
The GrpcResponseWriter used to do all the mapping of the responses. This should not be the responsibility of this class. It should only be responsible for writing the responses to the correct requests. The mapping itself has now been extracted into a separate GrpcResponseMapper class. (cherry picked from commit a6ff9d6)
We now use the GrpcResponseMapper to map the valueBufferView to a proper rpc response. The sending of the responses has been relocated to the GrpcResponseWriter as it is the responsibility of this class. (cherry picked from commit 4d7b440)
Creates the GatewayRequestStore and makes it available in the GrpcResponseWriter and the GrpcToLogStreamGateway. (cherry picked from commit 879ecbc)
Every command will now create its own RecordMetadata. This ensures the thread-safety of this class. (cherry picked from commit 51a917a)
Add javadoc to shortly describe why there is a GatewayRequestStore (cherry picked from commit acaa2a8)
The GrpcToLogStreamGateway should not have to worry about any concurrency issues. By extracting the command writing to a separate class we have this logic isolated. (cherry picked from commit 40b73c1)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #358 to
stable/8.0.relates to #349