Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling environment variable override for ZeebeClient in test #376

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

berndruecker
Copy link
Member

See #375

This PR can only be merged with the latest 8.1.0-SNAPSHOT as of today which seems to bring other changes that need to be adjusted first. I prep it anyway and ask to merge (or reimplement) this before releasing the next version (please :-)). Thx!

@github-actions
Copy link

github-actions bot commented May 25, 2022

Unit Test Results

  44 files    44 suites   1m 20s ⏱️
104 tests 104 ✔️ 0 💤 0
331 runs  331 ✔️ 0 💤 0

Results for commit a1a5265.

♻️ This comment has been updated with latest results.

@remcowesterhoud remcowesterhoud self-requested a review May 31, 2022 12:54
@remcowesterhoud remcowesterhoud self-assigned this May 31, 2022
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @berndruecker! 🚀

@remcowesterhoud remcowesterhoud merged commit 2515f50 into main Jun 7, 2022
@remcowesterhoud remcowesterhoud deleted the disable-environment-overrides branch June 7, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants