Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use different default port #398

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Jun 14, 2022

Description

Changes the default port in order to not conflict with a Zeebe instance running on the same port.

(does not address the request to make the port configurable)

Related issues

relates to #366

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

Changes the default port in order to not conflict with a Zeebe instance running on the same port.
@github-actions
Copy link

Unit Test Results

  44 files    44 suites   1m 18s ⏱️
104 tests 104 ✔️ 0 💤 0
331 runs  331 ✔️ 0 💤 0

Results for commit 3d2b6c1.

@pihme pihme requested a review from saig0 June 14, 2022 09:39
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pihme LGTM 👍

@pihme pihme merged commit 6b8109f into main Jun 14, 2022
@pihme pihme deleted the 366-use-different-default-port branch June 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants