-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated example #399
Merged
Merged
Dedicated example #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pihme
force-pushed
the
367-module-for-examples
branch
from
June 14, 2022 13:13
2b178fb
to
c5c6581
Compare
pihme
force-pushed
the
367-module-for-examples
branch
from
June 14, 2022 15:23
25ed766
to
2b6ee1b
Compare
The logic to activate a service task was rewritten to use only the Zeebe client API. This makes more sense to a user then interpreting exported records.
The logic to activate a user task was rewritten to use only the Zeebe client API. This makes more sense to a user than interpreting exported records.
pihme
force-pushed
the
367-module-for-examples
branch
from
June 15, 2022 13:02
7bb56a0
to
4583307
Compare
saig0
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pihme I like it 👍 Good job 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Initially we wanted to use our own tests also as examples to avoid duplicating code. However, our own tests are not ideal as examples:
We also have a more complex tests, which uses different assertions in combination. But this test was hard to find among all the other files and also suffered from aforementioned problems.
Change
This PR
Related issues
closes #367
Definition of Done
Code changes:
Testing:
Documentation: