Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ephemeral free port #405

Merged
merged 1 commit into from
Jun 16, 2022
Merged

chore: use ephemeral free port #405

merged 1 commit into from
Jun 16, 2022

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Jun 16, 2022

Description

Now uses a free ephemeral port by default

Related issues

closes #366

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@pihme pihme marked this pull request as ready for review June 16, 2022 07:52
@pihme pihme requested a review from saig0 June 16, 2022 07:53
@github-actions
Copy link

Unit Test Results

  44 files    44 suites   1m 19s ⏱️
104 tests 104 ✔️ 0 💤 0
331 runs  331 ✔️ 0 💤 0

Results for commit dcbd94f.

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pihme nice 👍

@pihme pihme merged commit 5d56825 into main Jun 16, 2022
@pihme pihme deleted the 366-use-dynamic-free-port branch June 16, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zeebe Test engine should start on a different port
2 participants