Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For local builds (on a developer's workstation) a Docker image is built by Maven on the fly. This image is then used in QA tests with testcontainers. All tests locally will be run with Java 17.
The GitHub workflows should be unperturbed by this change.
Review hints
Please have a look at the issue for the intended scope of the change.
I think there could be further steps to also use Maven to build the Docker image as part of the GHA workflows, but I wanted to keep the change set small.
Now, effectively Maven will build a local Docker image that is tagged with the project version and GHA for build and test will build a Docker image that is tagged with the SHA value. So the two shouldn't conflict with each other 🤞
I was also wondering whether we should document this #407 (comment) as part of some developer documentation. Basically, I always need an hour or two to wrap my head around how this works in detail. It is easy to see from the GHA workflows what is happening, but not so easy to piece together why it needs to happen in that way. Please let me know what you think.
This will also use the default time stamping for the created images. Please read the reasoning here: https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md#why-is-my-image-created-48-years-ago I opted not to deviate from the default. Again, please let me know what you think
Related issues
closes #407
Definition of Done
Code changes:
Testing:
Documentation: