Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/8.0] Update paths to vault secrets in CI #451

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

npepinpe
Copy link
Member

Description

Backports #439 and #448 to stable/8.0. I assume the old secrets will be deleted before we get rid of this branch, since we still need to support it for 8 months.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@npepinpe npepinpe requested a review from remcowesterhoud July 26, 2022 12:16
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nicolas 👍

@github-actions
Copy link

Unit Test Results

   152 files     152 suites   6m 30s ⏱️
   268 tests    268 ✔️ 0 💤 0
1 028 runs  1 028 ✔️ 0 💤 0

Results for commit 9e9d407.

@remcowesterhoud remcowesterhoud merged commit 046ed5a into stable/8.0 Jul 26, 2022
@remcowesterhoud remcowesterhoud deleted the backport-439-to-stable/8.0 branch July 26, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants