Fully support Process Instance Modification #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remcowesterhoud
force-pushed
the
466_pi_modification
branch
from
9d7234a to
9966bde
Compare
korthout
approved these changes
Sep 16, 2022
engine/src/test/java/io/camunda/zeebe/process/test/engine/EngineClientTest.java
Outdated
Show resolved
Hide resolved
This test verifies we can send a process instance modification request and receive a corresponding response.
A process instance modification request returns an empty response. We need to add ouw own mapper for this empty response here.
remcowesterhoud
force-pushed
the
466_pi_modification
branch
from
9966bde to
d79b9c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the PI modification command by adding it to the ZPT gateway. Handling the incoming request was already taken care of in #461.
With this PR we now map the Response of the request as well. For modification this is an empty response. It also adds a testcase to verify that modifying a process instance works. This test is not meant as an exhaustive test for the modification logic. What we're interested in is making sure the request is handled properly by the gateway.
Related issues
closes #466
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: