Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stable/8.1 back into main #533

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Merge stable/8.1 back into main #533

merged 2 commits into from
Oct 13, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Oct 13, 2022

Description

The release processes doesn't contain the step to merge this branch back. Without it the release commits will be unavailable on the main branch, causing strange versioning.

I will modify the release process to include this step.

Related issues

closes #

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

Test Results

  47 files    47 suites   2m 6s ⏱️
113 tests 113 ✔️ 0 💤 0
362 runs  362 ✔️ 0 💤 0

Results for commit c399518.

Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) 💯

@remcowesterhoud remcowesterhoud merged commit 8234d54 into main Oct 13, 2022
@remcowesterhoud remcowesterhoud deleted the stable/8.1 branch October 13, 2022 12:30
@remcowesterhoud remcowesterhoud restored the stable/8.1 branch October 13, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants