Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dmn model dependency convergence issue #541

Merged
1 commit merged into from
Oct 14, 2022
Merged

Fix dmn model dependency convergence issue #541

1 commit merged into from
Oct 14, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Oct 14, 2022

Description

The Zeebe version is set to the SNAPSHOT version in order to resolve this issue. If we don't the main branch would expect version 7.17.0 of the dmn-model. The nightly tests against SNAPSHOT would expect version 7.18.0. Whichever version we'd pick, one of those would always be broken. By changing te main branch to Zeebe SNAPSHOT we resolve this issue.

Related issues

closes #538

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

The Zeebe version is set to the SNAPSHOT version in order to resolve this issue. If we don't the main branch would expect version 7.17.0 of the dmn-model. The nightly tests against SNAPSHOT would expect version 7.18.0. Whichever version we'd pick, one of those would always be broken. By changing te main branch to Zeebe SNAPSHOT we resolve this issue.
@github-actions
Copy link

Test Results

  47 files  ±0    47 suites  ±0   1m 58s ⏱️ +8s
113 tests ±0  113 ✔️ ±0  0 💤 ±0  0 ±0 
362 runs  ±0  362 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 34fb9b1. ± Comparison against base commit 8533712.

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @remcowesterhoud LGTM 👍

@remcowesterhoud
Copy link
Contributor Author

bors merge

@ghost
Copy link

ghost commented Oct 14, 2022

Build succeeded:

  • Test summary

@ghost ghost merged commit 31e2b78 into main Oct 14, 2022
@ghost ghost deleted the bump_dmn_model branch October 14, 2022 14:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build of Snapshot version is broken due to dependency convergence
2 participants