Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): add escalation valuetype logger #556

Merged
1 commit merged into from
Nov 2, 2022

Conversation

koevskinikola
Copy link
Member

Description

Add a logger for the Escalation ValueType. The Escalation ValueType was added recently, and there is no corresponding logger in the zeebe-process-test library. This causes the testAllValueTypesAreMapped() test to fail.

Related issues

closes #551

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

* Add a logger for the Escalation ValueType. The Escalation ValueType was added recently, and there is no corresponding logger in the zeebe-process-test library. This causes the testAllValueTypesAreMapped() test to fail.
@koevskinikola koevskinikola self-assigned this Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Test Results

  47 files  ±0    47 suites  ±0   2m 3s ⏱️ +13s
113 tests ±0  113 ✔️ ±0  0 💤 ±0  0 ±0 
362 runs  ±0  362 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 4fc3697. ± Comparison against base commit 9aa0f89.

@remcowesterhoud remcowesterhoud marked this pull request as ready for review November 2, 2022 16:20
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

bors merge

@ghost
Copy link

ghost commented Nov 2, 2022

Build succeeded:

@ghost ghost merged commit 2863c92 into main Nov 2, 2022
@ghost ghost deleted the 551-escalation-value-type-logger branch November 2, 2022 16:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No value type logger defined for value type 'ESCALATION'
2 participants