Inject ZPT related fields into superclasses #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extensions should inject the ZeebeClient and the ZeebeTestEngine into the fields available with this type. This test will verify that this happens for both the embedded engine and the testcontainers engine.
The extensions should inject the engine, client and recordstream into the fields that are available. Before this only tried to inject them into the annotated class. This does not work when inheritance is used and the fields are defined on the superclass of the annotated class. This commit changes the extension so that it will first look on the annotated class. If it cannot find any of the annotations here, it will work it's way up to the superclass and so on until it either found a field it is able to inject, or no fields at all.
koevskinikola
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
LGTM! 🚀
@remcowesterhoud thanks for passing the review to me. It was a nice chance to learn how the extension works.
I raised one point for discussion below, so this is why I didn't ask bors to merge the PR. It's optional, so fell free to merge it if you want to.
Comment on lines
+147
to
+151
| } else if (fields.size() == 0) { | ||
| final Class<?> superclass = requiredTestClass.getSuperclass(); | ||
| return superclass == null ? Optional.empty() : getField(superclass, object); | ||
| } else { | ||
| return Optional.of(fields.get(0)); |
There was a problem hiding this comment.
👍 Nice, it will go up in the hierarchy until if finds something.
.../test/java/io/camunda/zeebe/process/test/qa/embedded/injection/InheritanceInjectionTest.java
Show resolved
Hide resolved
|
bors merge |
|
Build succeeded: |
ghost
merged commit 
|
Successfully created backport PR #608 for |
|
Successfully created backport PR #609 for |
ghost
pushed a commit
that referenced
this pull request
Dec 15, 2022
ghost
pushed a commit
that referenced
this pull request
Dec 15, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The extensions should inject the engine, client and recordstream into the fields that are available. Before this only tried to inject them into the annotated class. This does not work when inheritance is used and the fields are defined on the superclass of the annotated class.
This PR changes the extensions so that it will first look on the annotated class. If it cannot find any of the annotations here, it will work it's way up to the superclass and so on until it either found a field it is able to inject, or no fields at all.
Related issues
closes #604
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: