Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResourceDeletion ValueType to the logger #650

Merged
1 commit merged into from
Feb 1, 2023
Merged

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Feb 1, 2023

Description

Adds a logger for the new ResourceDeletion ValueType. This record only contains a resource key.

Related issues

closes #443

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

Adds a logger for the new ResourceDeletion ValueType. This record only contains a resource key.
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Test Results

  47 files  ±0    47 suites  ±0   1m 56s ⏱️ +10s
116 tests ±0  116 ✔️ ±0  0 💤 ±0  0 ±0 
371 runs  ±0  371 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 94fe10d. ± Comparison against base commit f107d9e.

Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

bors merge

@ghost
Copy link

ghost commented Feb 1, 2023

Build succeeded:

  • Test summary

@ghost ghost merged commit 4be4573 into main Feb 1, 2023
@ghost ghost deleted the resource_deletion_logger branch February 1, 2023 10:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resource deletion records to the logger
2 participants