Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resizable field to BaseWindow #172

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add resizable field to BaseWindow #172

merged 1 commit into from
Sep 17, 2024

Conversation

beef331
Copy link
Contributor

@beef331 beef331 commented Sep 16, 2024

…hich also forces floating in most tiling managers.

@can-lehmann
Copy link
Owner

I think this should be part of BaseWindow such that it can also be used in AdwWindow.

@beef331 beef331 force-pushed the window_resizable branch 2 times, most recently from 7e481f6 to cfbb9c9 Compare September 17, 2024 01:33
can-lehmann
can-lehmann reviewed Sep 17, 2024
View reviewed changes
owlkettle/widgets.nim Outdated Show resolved Hide resolved
@can-lehmann can-lehmann changed the title Added resizable property to window allowing for fixed sized windows w… Add resizable field to BaseWindow Sep 17, 2024
@can-lehmann
Copy link
Owner

Please run nimble genDocs since we still link directly to the reference documents in the repo.

@beef331
Added resizable property to window allowing for fixed sized windows w…
48a5a65 
…hich also forces floating in most tiling managers.
@can-lehmann can-lehmann merged commit 405e22b into can-lehmann:main Sep 17, 2024
2 checks passed
@can-lehmann
Copy link
Owner

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@can-lehmann can-lehmann can-lehmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beef331 @can-lehmann