Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for wrapping gtk widgets for new contributors #91

Merged

Conversation

PhilippMDoerner
Copy link
Contributor

@PhilippMDoerner PhilippMDoerner commented Sep 30, 2023

Because I dislike having to ask the same thing twice I tend to write everything down.
So basically I had a ton of notes from wrapping the Scale widget and from our discussion surrounding that.

Given that this might be useful for any future contributors I thus then decided to clean up those notes a little and add them to the nimibook, because why not at that point.

This is the first draft on how such a chapter could look like, as per the usual all of this is freely changeable.
The point after all is to have the best introductory docs for newcomers possible to increase the likelihood of others contributing.

@PhilippMDoerner PhilippMDoerner changed the title Add docs for wrapping widget Add docs for wrapping gtk widgets for new contributors Sep 30, 2023
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
@PhilippMDoerner PhilippMDoerner marked this pull request as ready for review October 2, 2023 16:08
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
book/internals/wrap_gtk_widget.nim Outdated Show resolved Hide resolved
PhilippMDoerner and others added 7 commits October 3, 2023 15:47
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
@PhilippMDoerner
Copy link
Contributor Author

We can of course keep going here, but I'd want to have #94 merged first so that I can update the example application provided here first.

@can-lehmann
Copy link
Owner

From my point of view, this is actually quite close to merging already. Not sure what is more convenient for you, but at least for me it is easier to review one larger PR instead of multiple smaller ones that influence each other in various ways.

@can-lehmann can-lehmann mentioned this pull request Oct 4, 2023
@PhilippMDoerner
Copy link
Contributor Author

PhilippMDoerner commented Oct 4, 2023

From my point of view, this is actually quite close to merging already. Not sure what is more convenient for you, but at least for me it is easier to review one larger PR instead of multiple smaller ones that influence each other in various ways.

Ohhhhh I'll note that down for the future. I tend to prefer multiple smaller PRs to keep separate things in separate boxes in my head.
If fewer larger PRs are better for you I'm happy to accommodate.

If you're happy with this as is (I resolved the last few open topics we had) I'm happy to merge this branch into #95 and close this PR.

@can-lehmann can-lehmann merged commit 08a8739 into can-lehmann:main Oct 4, 2023
3 checks passed
@can-lehmann
Copy link
Owner

I merged directly into main, since the changes for #95 should be quite small & I consider this PR mostly finished at this point.

@PhilippMDoerner PhilippMDoerner deleted the add-docs-for-wrapping-widget branch October 17, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants