-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for wrapping gtk widgets for new contributors #91
Add docs for wrapping gtk widgets for new contributors #91
Conversation
This tells nimibook to build the book using the local owlkettle version instead of any installed version.
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
Also explain that it may be optional
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
Co-authored-by: Can Lehmann <85876381+can-lehmann@users.noreply.github.com>
We can of course keep going here, but I'd want to have #94 merged first so that I can update the example application provided here first. |
From my point of view, this is actually quite close to merging already. Not sure what is more convenient for you, but at least for me it is easier to review one larger PR instead of multiple smaller ones that influence each other in various ways. |
Ohhhhh I'll note that down for the future. I tend to prefer multiple smaller PRs to keep separate things in separate boxes in my head. If you're happy with this as is (I resolved the last few open topics we had) I'm happy to merge this branch into #95 and close this PR. |
I merged directly into main, since the changes for #95 should be quite small & I consider this PR mostly finished at this point. |
Because I dislike having to ask the same thing twice I tend to write everything down.
So basically I had a ton of notes from wrapping the Scale widget and from our discussion surrounding that.
Given that this might be useful for any future contributors I thus then decided to clean up those notes a little and add them to the nimibook, because why not at that point.
This is the first draft on how such a chapter could look like, as per the usual all of this is freely changeable.
The point after all is to have the best introductory docs for newcomers possible to increase the likelihood of others contributing.