Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

461 numbering questions results page #872

Merged
merged 9 commits into from
Nov 29, 2021

Conversation

Ancentury
Copy link
Contributor

No description provided.

@Ancentury Ancentury self-assigned this Nov 27, 2021
@Ancentury Ancentury linked an issue Nov 27, 2021 that may be closed by this pull request
@MrDeshaies
Copy link
Contributor

Hi @Ancentury; numbering looks to be working well. But there remains a spacing issue which is described in ticket #461.

There's a space between the question and the answer for questions 1, 2, 4, 5, 6, but not for questions 3 and 7. A difference between TextResult and the MultiChoiceResult ? We would like to answer to be close to the question.

Good:

Question 1
Answer1

Question 2
Answer2

Bad:

Question 1

Answer1
Question 2

Answer 2

image

@Ancentury
Copy link
Contributor Author

@MrDeshaies Fixed. Please check again. Thanks.

Copy link
Contributor

@MrDeshaies MrDeshaies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results look great now! Answers are close to the question. Numbering works well, even with dynamic questions (e.g. those on data using personal info)

@MrDeshaies MrDeshaies merged commit 0ca0112 into master Nov 29, 2021
@MrDeshaies MrDeshaies deleted the 461-numbering-questions-results-page branch November 29, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbering and Formatting of Questions & Answers on the Results Page
2 participants