Merge pull request #21 from FociSolutions/3-turn-bootstrap-action-var…

…iable-creation-into-secrets Changed some GH action vars to secrets
canada-ca · Feb 29, 2024 · 9c14ca2 · 9c14ca2
2 parents fb86fa0 + 0a72857
commit 9c14ca2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/bootstrap/variables.tf b/bootstrap/variables.tf
@@ -8,11 +8,6 @@ variable "billing_account" {
   type        = string
 }
 
-variable "terraform_service_account" {
-  description = "Service account email of the account to impersonate to run Terraform."
-  type        = string
-}
-
 #Github variables
 variable "github_enterprise_slug" {
   type        = string

diff --git a/organizations/.github/workflows/drift-detection.yaml b/organizations/.github/workflows/drift-detection.yaml
@@ -44,8 +44,8 @@ jobs:
         id: auth
         uses: google-github-actions/auth@v2
         with:
-          workload_identity_provider: "${{ vars.WORKLOAD_IDENTITY_PROVIDER }}"
-          service_account: "${{ vars.GCP_SERVICE_ACCOUNT }}"
+          workload_identity_provider: "${{ secrets.WORKLOAD_IDENTITY_PROVIDER }}"
+          service_account: "${{ secrets.GCP_SERVICE_ACCOUNT }}"
 
       - name: Check Terraform Format
         id: fmt
@@ -153,8 +153,8 @@ jobs:
         id: auth
         uses: google-github-actions/auth@v2
         with:
-          workload_identity_provider: "${{ vars.WORKLOAD_IDENTITY_PROVIDER }}"
-          service_account: "${{ vars.GCP_SERVICE_ACCOUNT }}"
+          workload_identity_provider: "${{ secrets.WORKLOAD_IDENTITY_PROVIDER }}"
+          service_account: "${{ secrets.GCP_SERVICE_ACCOUNT }}"
 
       - name: Check Terraform Format
         id: fmt

diff --git a/organizations/.github/workflows/on-pull-and-push.yaml b/organizations/.github/workflows/on-pull-and-push.yaml
@@ -38,8 +38,8 @@ jobs:
         id: auth
         uses: google-github-actions/auth@v2
         with:
-          workload_identity_provider: "${{ vars.WORKLOAD_IDENTITY_PROVIDER }}"
-          service_account: "${{ vars.GCP_SERVICE_ACCOUNT }}"
+          workload_identity_provider: "${{ secrets.WORKLOAD_IDENTITY_PROVIDER }}"
+          service_account: "${{ secrets.GCP_SERVICE_ACCOUNT }}"
 
       - name: Check Terraform Format
         id: fmt