Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix domain removal #3759

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Fix domain removal #3759

merged 5 commits into from
Jun 1, 2022

Conversation

FestiveKyle
Copy link
Collaborator

@FestiveKyle FestiveKyle commented May 31, 2022 •
edited
Loading

As described

Closes #3525

lcampbell2
lcampbell2 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@lcampbell2 lcampbell2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FestiveKyle FestiveKyle merged commit 8842da7 into master Jun 1, 2022
@FestiveKyle FestiveKyle deleted the fix-domain-removal branch June 1, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcampbell2 lcampbell2 lcampbell2 approved these changes

@sleepycat sleepycat Awaiting requested review from sleepycat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot remove long-lived domains
2 participants
@FestiveKyle @lcampbell2