fix: Handle offset values #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'offset' of github.com:webmasterkai/canboatjs: fix: Handle offset values
* 'offset' of github.com:webmasterkai/canboatjs: fix: Handle offset values
|
The changes to test.js are to enable multiple tests for each pgn. |
|
I’m trying to figure out why I commented that out... |
|
If it results in a problem I promise to help write the failing tests and then fix the code so they pass. Without this, the test for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a issue with the info related to PGN 65026. canboat/canboat#145
The test file in this project was modified from the original feed.
original:
2016-02-28T19:57:02.826Z,3,65026,196,255,8,42,96,35,77,83,96,35,7765026.js:
2016-02-28T19:57:02.826Z,3,65026,196,255,8,42,96,35,77,ff,ff,ff,ffI updated the test to contain the correct hex values and included two more examples. I had to adjust the test script to handle multiple tests for a single PGN.
Lastly I uncommented the offset handling code to get the correct values. Was there a reason the offset code was commented out? In this very specific example it works as expected.