Add dummy sheet test #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@turbomam @jooho-lee-kim You don't need to review this PR (unless you want to!), but I just wanted to let you both know that this test now exists. Let me know if you have any ideas on improving it, either in this PR or in another one! |
gaurav
force-pushed
the
add-dummy-sheet-test
branch
from
349df54 to
f431144
Compare
This is because the CCDH Terminology Service endpoint changed.
This environmental variable can be used to access file (see https://pygsheets.readthedocs.io/en/stable/authorization.html#service-account for details).
gaurav
force-pushed
the
add-dummy-sheet-test
branch
from
f431144 to
2870a01
Compare
This is because @cached_property isn't supported in Python 3.7, blech.
sujaypatil96
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
All the changes and tests in this PR are great @gaurav. Awesome job.🎉
I've left some very very trivial comments on this PR, which can choose not to address, they're not critical at all. So approving this PR for merge.🚀
See https://docs.python.org/3/library/constants.html#exit for recommendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "dummy sheet test" (#8) -- it runs sheet2linkml with a Google Sheet I've created solely for testing at https://docs.google.com/spreadsheets/d/1HpsF12vl_CeIzV2TEtANeysnh7cy6YOUDdv6fMXT00I/edit#gid=1810442705, and ensures that the output is identical to the schema generated on previous runs, which is included in this PR.
In addition to this, this PR also fixes some minor bugs found along with the way:
pytestto support testing.logging_configandgoogle_sheet_idcommand line arguments are set before using them.0in case of successful execution.print()withlogging.debug().