Escape double-quotes in labels, and suppress labels with value nil

Fixes grafana#927
candlerb · Aug 21, 2019 · ca6723f · ca6723f
1 parent fdafa10
commit ca6723f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/fluentd/fluent-plugin-grafana-loki/lib/fluent/plugin/out_loki.rb b/fluentd/fluent-plugin-grafana-loki/lib/fluent/plugin/out_loki.rb
@@ -135,10 +135,8 @@ def labels_to_protocol(data_labels)
         data_labels = {} if data_labels.nil?
         data_labels = data_labels.merge(@extra_labels)
 
-        unless data_labels.nil?
-          data_labels.each do |k, v|
-            formatted_labels.push("#{k}=\"#{v}\"")
-          end
+        data_labels.each do |k, v|
+          formatted_labels.push("#{k}=\"#{v.gsub('"','\\"')}\"") if v
         end
         '{' + formatted_labels.join(',') + '}'
       end