One-on-one profile pane #272
Conversation
…e resource they came from
…he last used to send me a message In case I haven't yet received a message from him, I will send to his bare JID
This currently causes a flash with a re-request for the vCard because the user instance is fresh. We should instead try and find the user instance from the "room's" roster, though I'm not sure this is stored for 1-on-1.
|
@mweibel In a lot of this work I'm coming up against a requirement for certain features to be present in Candy core (basic presence routing, etc) which rely on concepts of a general chat client (with a main roster, individual contacts, etc) that Candy doesn't have (some of which we have implemented in plugins). Are you actively against some of these things being brought in to Candy core to make it a more general and capable XMPP client (noting that I do not necessarily mean any UI changes, but purely laying the state foundations for easily building these as plugins)? If your general stance is "do it in plugins", what do I do when there's such a circular dependency between plugin -> candy core -> plugin? |
|
About your question: I basicly misunderstood what you wanted with this other PR which I said to do as a plugin. I think it's appropriate to bring in more XMPP features even if they are not directly MUC-related. UI changes we can always discuss, but they might be better in plugins. |
|
Excellent, expect a deluge of PRs adding more core XMPP functionality. Thanks for your input :) |
|
Neat :) |
|
Btw. Off Topic: Do you think it would help if we'd use Gitter (https://gitter.im/candy-chat) for better communication in certain cases? |
|
Is this on hold as well right now? |
|
Yes, I'll be submitting a separate PR for some additions of roster stuff to Candy core to make this easier to implement properly. |
|
@mweibel Would you be amenable to using https://github.com/nilclass/vcardjs to replace the buggy vcard representation here? |
|
Yeah might be better I guess |
|
What's the status here? |
|
Closing as no update has been happening. Reopen if you don't agree. |
Replaces the roster pane in a one-on-one chat window with a profile pane similar to HipChat.
Builds on #268. That should be merged first.
This may require some styling work.