-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing #244
Merged
Merged
Tracing #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit add41fc.
jwbot
added
P: Compiler: Frontend
Package: The compiler frontend
P: Core
Package: Candy's standard library
labels
Oct 17, 2022
Co-authored-by: Jonas Wanke <contact@jonas-wanke.com>
Co-authored-by: Jonas Wanke <contact@jonas-wanke.com>
Co-authored-by: Jonas Wanke <contact@jonas-wanke.com>
Co-Authored-By: Jonas Wanke <contact@wanke.dev>
Co-Authored-By: Jonas Wanke <contact@wanke.dev>
Co-Authored-By: Jonas Wanke <contact@wanke.dev>
Co-Authored-By: Jonas Wanke <contact@wanke.dev>
Co-Authored-By: Jonas Wanke <contact@wanke.dev>
JonasWanke
reviewed
Oct 30, 2022
Co-authored-by: Jonas Wanke <contact@jonas-wanke.com>
Co-authored-by: Jonas Wanke <contact@jonas-wanke.com>
Co-authored-by: Jonas Wanke <contact@jonas-wanke.com>
JonasWanke
approved these changes
Oct 31, 2022
JonasWanke
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #241
#241 changed the VM architecture a lot. In particular, it introduced the ability to run several concurrently running fibers. This broke tracing, which still relied on some assumptions such as all objects being in a single heap.
This PR fixes the tracing by moving the tracer outside of the fiber's and VM's ownership. Instead, the tracer is borrowed to the
vm.run
method, along with the other existing context parts passed to it. Depending on the amount of insight that the outside world wants to get into the execution, it can pass in different tracers. The following tracers exist for now:We can use the full tracer to figure out exactly what happened in the VM. Using this, we can correctly output which part of the code is responsible and we have nice stack traces, even across fibers.
Previously, we also supported a hierarchical trace dump that related calls to returns, etc. For now, in the new architecture, we only have a straightforward list of all events. However, I plan on introducing a Flamegraph-inspired graphical trace visualization that looks something like this:
This would allow us to do profiling of the Candy code itself and also see dependencies between fibers.