-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fuzzing to the CI #246
Conversation
In the logs, you may have noticed that the functions in I guess I'll start working on some basic optimizations such as function inlining, duplicate subtree elimination, and compile-time evaluation soon to fix the problem described above. LLVM would also do those optimizations, but we'd have to turn the entire tree (including expanded uses, thus an exponential amount of code) into LLVM-IR for it to do its magic, so that's too late in the pipeline and it makes sense to do these optimizations in Candy itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Jonas Wanke <contact@jonas-wanke.com>
Fuzzing works fine locally. Seems like this is an issue of nightly cargo: rust-lang/cargo#8557 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether the issue you linked is really related since it's been closed for more than two years, but I couldn't find a good-looking current one. Maybe we should disable the action for now so that we don't get used to the failing CI?
Other than that, the PR looks fine
Fair enough, I'll just disable the fuzzing for now |
Depends on #245
This makes the exit code of the
candy fuzz
command match whether errors were found during fuzzing. It also adds fuzzing to the CI and fixes some errors that were discovered.