Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE11 #443

Merged
merged 7 commits into from
Nov 8, 2018
Merged

Fix IE11 #443

merged 7 commits into from
Nov 8, 2018

Conversation

cherifGsoul
Copy link
Member

Separate can-observe tests and make sure it uses the fixed version of can-memory-store

test/test.js Outdated
@@ -4,7 +4,7 @@ require("../core_test");

require("../cache-requests/cache-requests_test");

require("../can/test");
require("../can/test-without-proxy");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run all the tests here, we should only run the without-proxy tests in canjs/canjs where we're testing IE11.

@cherifGsoul cherifGsoul merged commit ba386ee into master Nov 8, 2018
@cherifGsoul cherifGsoul deleted the ie11-compat branch November 8, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants