fix tests for IE11 #212
Merged
fix tests for IE11 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
test/route-define-test.js
Outdated
|
|
||
| mockRoute.stop(); | ||
| QUnit.start(); | ||
| },0.5); |
There was a problem hiding this comment.
Can you explain this? It's very good practice to put inline comments describing any changes that someone would not understand.
There was a problem hiding this comment.
If this change is needed, it really should be done inside _onStartComplete. The purpose of that function is to tell tests when they can do assertions.
That said, I still don't understand why this change is needed. Why is _onStartComplete being called before things have settled?
|
I think this should be ready to go now, @cherifGsoul. There are still a few flaky tests that we need to fix, but they are not IE11 specific. I see them failing intermittently in Chrome also. |
phillipskevin
force-pushed
the
ie11-compat
branch
from
4a08a6c to
0ec0ed6
Compare
|
test-saucelabs is failing. I'll take a look in a bit. |
phillipskevin
force-pushed
the
ie11-compat
branch
from
0ec0ed6 to
8e217ed
Compare
phillipskevin
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can-observetests