Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated can-stache to be import stache from can-stache able #259

Closed
wants to merge 3 commits into from

Conversation

frank-dspeed
Copy link
Contributor

Updated can-stache to be import stache from can-stache able

@justinbmeyer
Copy link
Contributor

What Is this for? Why export with two different formats?

@matthewp
Copy link
Contributor

matthewp commented Aug 4, 2017

This won't work. We either need this: stealjs/transpile#73 to support ES modules or convert manually to ES and transpile to CJS.

@frank-dspeed
Copy link
Contributor Author

@justinbmeyer because i regonized that i simply cant do import stache from can-stache and i corrected it tthis way in all my libs so i tought this will work here also.

@justinbmeyer
Copy link
Contributor

@matthewp / @frank-dspeed why can't you do this? Is this because ES6 syntax doesn't use the main export of a CJS module?

@justinbmeyer
Copy link
Contributor

Closing until we figure out why this is needed. @frank-dspeed it might help to create an issue for this first.

@matthewp
Copy link
Contributor

From a steal perspective a module cannot have two formats, it cannot be both an ESM (having exports) and a CommonJS module. I think webpack supports this, but steal doesn't, the browser doesn't, and Node.js isn't going to.

@frank-dspeed
Copy link
Contributor Author

@matthewp i use this tech normaly with babel and i tought steal can handle it maybe also with babel i get a import and require able lib as expected and with nodejs this worked also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants